[3006.x] Connect callback closes it's request channel #65508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
s0undt3ch
approved these changes
Nov 3, 2023
s0undt3ch
approved these changes
Nov 14, 2023
This was referenced Nov 29, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Make sure publish channel's connect_callback method closes the request channel it creates.
What issues does this PR fix or reference?
Fixes: #65464
Previous Behavior
The connect callback would create a request channel and delete but but never called it's close method
New Behavior
The newly created request channel is closed after being used.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.