Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] remove get event transport arg #64465

Merged
merged 2 commits into from
Jun 18, 2023

Conversation

cmcmarrow
Copy link
Contributor

@cmcmarrow cmcmarrow commented Jun 12, 2023

What does this PR do?

Remove transport arg from salt.utils.event.get_even

What issues does this PR fix or reference?

Fixes: #64461

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@cmcmarrow cmcmarrow requested a review from a team as a code owner June 12, 2023 16:24
@cmcmarrow cmcmarrow requested review from MKLeb and removed request for a team June 12, 2023 16:24
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title remove get event transport arg [3006.x] remove get event transport arg Jun 12, 2023
@cmcmarrow cmcmarrow temporarily deployed to ci June 12, 2023 16:45 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 12, 2023 16:45 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 12, 2023 16:45 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 12, 2023 16:50 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 12, 2023 17:06 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 12, 2023 17:09 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 12, 2023 18:17 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 12, 2023 18:17 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 12, 2023 18:17 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 12, 2023 18:17 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 12, 2023 18:17 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 12, 2023 18:17 — with GitHub Actions Inactive
@Ch3LL
Copy link
Contributor

Ch3LL commented Jun 12, 2023

This needs to be pointed to the master branch.

MKLeb
MKLeb previously approved these changes Jun 12, 2023
@cmcmarrow cmcmarrow changed the base branch from 3006.x to master June 16, 2023 16:18
@cmcmarrow cmcmarrow dismissed MKLeb’s stale review June 16, 2023 16:18

The base branch was changed.

@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title [3006.x] remove get event transport arg [master] remove get event transport arg Jun 16, 2023
@s0undt3ch s0undt3ch merged commit dbea252 into saltstack:master Jun 18, 2023
@s0undt3ch s0undt3ch deleted the remove_get_event_transport_arg branch June 18, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TECH DEBT] Remove transport arg from salt.utils.event.get_event
4 participants