[3006.x] Fix lgpo.get functions not returning all boolean values #64414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
This was
linked to
issues
Jun 2, 2023
Ch3LL
previously approved these changes
Jun 5, 2023
twangboy
force-pushed
the
fix_63473
branch
2 times, most recently
from
1ae4806
to
bfd701e
Compare
s0undt3ch
suggested changes
Jun 7, 2023
s0undt3ch
approved these changes
Jun 10, 2023
|
This PR has fixed some GPO Policies, but then I tried these 2 GPO polices using 3007.1. They work the first time but fail subsequently. "Interactive logon: Number of previous logons to cache (in case domain controller is not available)" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes an issue with the LGPO execution module where not all boolean values were being returned. This was affecting the
lgpo.setstate that was expecting to see the boolean settings present, but were instead missing.The problem had to do with the eTree Element object. Sometimes it is an Element with a length of 0 that would not be reported. Other times it is an Element with a length greater than 0, which would be reported.
What issues does this PR fix or reference?
Fixes:
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes