Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3006.x] Issue 64111 #64116

Closed
wants to merge 2 commits into from
Closed

[3006.x] Issue 64111 #64116

wants to merge 2 commits into from

Conversation

dwoz
Copy link
Contributor

@dwoz dwoz commented Apr 20, 2023 •
edited
Loading

@dwoz dwoz requested a review from a team as a code owner April 20, 2023 00:05
@dwoz dwoz requested review from garethgreenaway and removed request for a team April 20, 2023 00:05
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Issue 64111 [3006.x] Issue 64111 Apr 20, 2023
@dwoz dwoz temporarily deployed to ci April 20, 2023 00:24 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci April 20, 2023 00:24 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci April 20, 2023 00:24 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci April 20, 2023 02:00 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci April 20, 2023 02:00 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci April 20, 2023 02:00 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci April 20, 2023 02:50 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci April 20, 2023 02:50 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci April 20, 2023 02:50 — with GitHub Actions Inactive
twangboy
twangboy previously approved these changes Apr 20, 2023
View reviewed changes
@twangboy
Copy link
Contributor

Looks like you got some pre-commit and lint failures

@dwoz
Add regression test for saltstack#64111
97b4f37 
Test importing jinja files
@dwoz
Do not close a cached file loader
017399a 
We don't want to close the file loader on a SaltCachedLoader object
because it is cached on the class and expected to be re-used between
multiple object instantiations.
@dwoz dwoz temporarily deployed to ci April 21, 2023 00:03 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci April 21, 2023 00:03 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci April 21, 2023 00:03 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci April 21, 2023 00:58 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci April 21, 2023 00:58 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci April 21, 2023 00:58 — with GitHub Actions Inactive
s0undt3ch
s0undt3ch reviewed Apr 21, 2023
View reviewed changes
salt/utils/templates.py
@@ -515,10 +515,6 @@ def opt_jinja_env_helper(opts, optname):
raise SaltRenderError(
"Jinja error: {}{}".format(exc, out), line, tmplstr, trace=tracestr
)
finally:
if loader and hasattr(loader, "_file_client"):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means the file client is left open? When is it closed?

@s0undt3ch
Copy link
Collaborator

Your test case is now included in #64113

@s0undt3ch
Copy link
Collaborator

The test case was included in #64113

@s0undt3ch s0undt3ch closed this Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s0undt3ch s0undt3ch s0undt3ch left review comments

@twangboy twangboy twangboy left review comments

@garethgreenaway garethgreenaway Awaiting requested review from garethgreenaway garethgreenaway was automatically assigned from saltstack/team-core

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dwoz @twangboy @s0undt3ch