Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with win_pkg.py #63949

Merged
merged 6 commits into from
Mar 28, 2023
Merged

Conversation

twangboy
Copy link
Contributor

@twangboy twangboy commented Mar 24, 2023

What does this PR do?

Fixes an issue with win_pkg.py handling versions that have strings. We need to use LooseVersion instead of Version. This became apparent with git releases 2.23.0 where the version number had the word windows in it, ie 2.23.0.windows.1. They only did this for two releases, but it throws a wrench in how Salt compares the versions.

Also removes /s from the command that runs the installer cmd /c vs cmd /s /c. The /s was causing an issue when there was a space in the path. This became an issue when we moved root_dir to ProgramData (C:\ProgramData\Salt Project\Salt). This was causing the following error:

'C:\ProgramData\Salt' is not recognized as an internal or external command, operable program or batch file.

What issues does this PR fix or reference?

Fixes: #63935

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@twangboy twangboy requested a review from a team as a code owner March 24, 2023 16:55
@twangboy twangboy requested review from garethgreenaway and removed request for a team March 24, 2023 16:55
@twangboy twangboy force-pushed the fix_win_pkg branch 4 times, most recently from bf17ec0 to 66e64e1 Compare March 27, 2023 17:04
@twangboy twangboy linked an issue Mar 27, 2023 that may be closed by this pull request
9 tasks
salt/modules/win_pkg.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [3006.0] Windows winrepo fails to install git
3 participants