fix file.managed creating temporary files in cwd

[Obbi89]

tempfile.mkstemp internally calls os.path.abspath on its dir argument, causing "" to be converted to the working directory of the process.

What does this PR do?

Change default for mkstemp call in state file.managed to prevent creation of temporary files in cwd.

What issues does this PR fix or reference?

Fixes: #63877

Previous Behavior

A file.managed state with check_cmd enabled will create temporary files in the processes working directory

New Behavior

A file.managed state with check_cmd enabled will create temporary files in the typical temporary folders - following the algorithm specified in pythons tempfile documentation.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

• Docs
• Changelog - https://docs.saltproject.io/en/master/topics/development/changelog.html
• Tests written/updated

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

[welcome]

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

• Community Wiki
• Salt’s Contributor Guide
• Join our Community Slack
• IRC on LiberaChat
• Salt Project YouTube channel
• Salt Project Twitch channel

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!

[Obbi89]

do we need a Testcase here? (the famous single line change, what bad could that ever do 🙃 )
The change shouldn't need any changelog mention either 🤷 as it doesn't change anything noticeable anyways.

[dwoz]

@Obbi89 are you able to add a changelog and a testcase?

[Obbi89]

Ah well, I did not get notified. I quickly took a look and tried to get something basic running

@dwoz You might have to point me to some examples to get this done right.
tbh. I'm not sure how to test this.

My approach now is:

• create a folder,
• chmod it to ugo-w
• use it as CWD for salt-call state.single file.managed check_cmd=/bin/true contents=['foobar']
  • (which will fail since cwd is not writeable. With my one-line fix however this state succeeds.)

To me this feels a bit nonsensical. It 'works' but does it actually test anything?

[Obbi89]

duplicate #66098
fixed by #66099