-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unbreak the gpg
state module
#63162
Unbreak the gpg
state module
#63162
Conversation
(while you're deep in the gpg state, do you fancy adding a PR for 59783 too?) |
9504473
to
acd2b4d
Compare
@twangboy Mind taking a look at this? The |
Is there any chance of getting this merged soon? This fixes basic functionality and I have several dependent PRs that I would like to get into 3007.0 as well. :) |
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
What does this PR do?
gpg
state module correctly report success and failure and honortest=true
.gpg.receive_keys
detect when a key could not be imported due to a missing user ID.gpg.receive_keys
detect when a key could not be imported due to an unreachable keyserver.gpg.absent
work withuser
/gnupghome
.gpg.delete_key
work withgnupghome
.name
/keys
, namely a key ID. Anything else will be detected as absent currently.What issues does this PR fix or reference?
Fixes: #65169
Fixes: #63153
Fixes: #63156
Fixes: #63144
Fixes: #63159
Fixes: #62129
Previous Behavior
Very broken. See linked issues for details.
New Behavior
Makes the state module work as intended, apart from trust management with
gnupghome
, which is still broken sincegpg.trust_key
does not support it currently.Merge requirements satisfied?
Commits signed with GPG?
Yes