Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak the gpg state module #63162

Merged
merged 24 commits into from
Nov 17, 2023
Merged

Unbreak the gpg state module #63162

merged 24 commits into from
Nov 17, 2023

Conversation

lkubb
Copy link
Contributor

@lkubb lkubb commented Nov 30, 2022

What does this PR do?

  • Makes the gpg state module correctly report success and failure and honor test=true.
  • Makes gpg.receive_keys detect when a key could not be imported due to a missing user ID.
  • Makes gpg.receive_keys detect when a key could not be imported due to an unreachable keyserver.
  • Makes gpg.absent work with user/gnupghome.
  • Makes gpg.delete_key work with gnupghome.
  • Fixes documentation regarding what needs to be passed in as name/keys, namely a key ID. Anything else will be detected as absent currently.

What issues does this PR fix or reference?

Fixes: #65169
Fixes: #63153
Fixes: #63156
Fixes: #63144
Fixes: #63159
Fixes: #62129

Previous Behavior

Very broken. See linked issues for details.

New Behavior

Makes the state module work as intended, apart from trust management with gnupghome, which is still broken since gpg.trust_key does not support it currently.

Merge requirements satisfied?

Commits signed with GPG?

Yes

@lkubb lkubb requested a review from a team as a code owner November 30, 2022 22:12
@lkubb lkubb requested review from twangboy and removed request for a team November 30, 2022 22:12
@OrangeDog
Copy link
Contributor

(while you're deep in the gpg state, do you fancy adding a PR for 59783 too?)

@lkubb
Copy link
Contributor Author

lkubb commented Feb 23, 2023

@twangboy Mind taking a look at this? The gpg state module does not deserve that label as it is sadly.

@lkubb lkubb temporarily deployed to ci April 23, 2023 20:32 — with GitHub Actions Inactive
@lkubb lkubb temporarily deployed to ci April 23, 2023 20:32 — with GitHub Actions Inactive
@lkubb lkubb temporarily deployed to ci April 23, 2023 20:32 — with GitHub Actions Inactive
@lkubb lkubb temporarily deployed to ci April 23, 2023 21:40 — with GitHub Actions Inactive
@lkubb lkubb temporarily deployed to ci April 23, 2023 21:40 — with GitHub Actions Inactive
@lkubb lkubb temporarily deployed to ci April 23, 2023 21:40 — with GitHub Actions Inactive
twangboy
twangboy previously approved these changes May 8, 2023
@twangboy twangboy added this to the Chlorine v3007.0 milestone May 8, 2023
@lkubb
Copy link
Contributor Author

lkubb commented Jun 11, 2023

Is there any chance of getting this merged soon? This fixes basic functionality and I have several dependent PRs that I would like to get into 3007.0 as well. :)

@lkubb lkubb temporarily deployed to ci July 5, 2023 13:37 — with GitHub Actions Inactive
@lkubb lkubb temporarily deployed to ci July 5, 2023 13:37 — with GitHub Actions Inactive
@lkubb lkubb temporarily deployed to ci July 5, 2023 13:37 — with GitHub Actions Inactive
@lkubb lkubb temporarily deployed to ci July 5, 2023 13:38 — with GitHub Actions Inactive
@lkubb lkubb temporarily deployed to ci July 5, 2023 13:56 — with GitHub Actions Inactive
Copy link

💔 All backports failed

Status Branch Result
3006.x Backport failed because of merge conflicts

You might need to backport the following PRs to 3006.x:
- Clean up new module unit tests
- Add test for issue 65169
- Backport fix for delete_key
- Backport more meaningful tests
- Add tests for issue 63159
- Fix gpg.receive_keys returns success on failed import
- Add tests for state module and issue 63144

Manual backport

To create the backport manually run:

backport --pr 63162

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment