Fix old root_dir paths on Windows #63030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MKLeb
previously approved these changes
Nov 7, 2022
MKLeb
previously approved these changes
Nov 8, 2022
Ch3LL
suggested changes
Nov 8, 2022
twangboy
force-pushed
the
cloud_paths
branch
from
8d3e4cd
to
18686a3
Compare
MKLeb
previously approved these changes
Nov 10, 2022
MKLeb
approved these changes
Nov 10, 2022
s0undt3ch
approved these changes
Nov 13, 2022
garethgreenaway
approved these changes
Nov 14, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the cloud salt util to place minion config in the correct Root Directory.
What issues does this PR fix or reference?
Fixes:
Previous Behavior
All config laid down by Salt Cloud was placed in the old Root Directory (
C:\Salt)New Behavior
All config laid down by Salt Cloud is not placed in the new Root Directory (
%PROGRAMDATA%\Salt Project\Salt)Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes