Update all platforms to use pycparser 2.21 or greater for Py 3.9 or higher, fixes fips fault with openssl v3.x #62419
Conversation
…nly` is passed to nox Signed-off-by: Pedro Algarvio <[email protected]>
When running the test suite it chunks, specially when running against the changed files, some of the test groups might not collect any test and Jenkins does not help with getting the exit code from scripts. This is where ``pytest-custom-exit-code` comes in, it allows exiting with a 0 exit code when no tests are collected. Signed-off-by: Pedro Algarvio <[email protected]>
…ting killed properly
Previously when changing a cron.present job from using a normal time specification to special or vice-versa, it would duplicate the entry in the crontab.
The original assertion used "mock_method.call_args.assert_called_with", which does nothing at all. Correct usage is either "mock_method.call_args == ..." or "mock_method.assert_called_with(...)"
This allows the cron.set_job and cron.set_special commands to change cron entries from special to non-special or vise-versa. It also removes all changes to states/cron from this PR's original commit, while retaining the behavioral changes to the cron.present state
…erry pi packages" This reverts commit 6f444ab.
Version 3005rc1
…th-merge update master with 3005rc1 tag via merge
```
tests\unit\modules\inspectlib\test_collector.py:27: in <module>
@skipIf(no_symlinks(), "Git missing 'core.symlinks=true' config")
Inspector = <class 'salt.modules.inspectlib.collector.Inspector'>
MagicMock = <class 'mock.mock.MagicMock'>
TestCase = <class 'tests.support.unit.TestCase'>
__builtins__ = <builtins>
__cached__ = 'C:\\Users\\Administrator\\AppData\\Local\\Temp\\kitchen\\testing\\tests\\unit\\modules\\inspectlib\\__pycache__\\test_collector.cpython-38.pyc'
__doc__ = '\n :codeauthor: Bo Maryniuk <[email protected]>\n'
__file__ = 'C:\\Users\\Administrator\\AppData\\Local\\Temp\\kitchen\\testing\\tests\\unit\\modules\\inspectlib\\test_collector.py'
__loader__ = <_pytest.assertion.rewrite.AssertionRewritingHook object at 0x0000022B0C3A6B20>
__name__ = 'tests.unit.modules.inspectlib.test_collector'
__package__ = 'tests.unit.modules.inspectlib'
__spec__ = ModuleSpec(name='tests.unit.modules.inspectlib.test_collector', loader=<_pytest.assertion.rewrite.AssertionRewritingHo...C:\\Users\\Administrator\\AppData\\Local\\Temp\\kitchen\\testing\\tests\\unit\\modules\\inspectlib\\test_collector.py')
no_symlinks = <function no_symlinks at 0x0000022B0D05CC10>
os = <module 'os' from 'c:\\python38\\lib\\os.py'>
patch = <function patch at 0x0000022B2836FB80>
skipIf = <function skipIf at 0x0000022B270738B0>
tests\support\helpers.py:82: in no_symlinks
output = subprocess.Popen(
output = ''
c:\python38\lib\subprocess.py:858: in __init__
self._execute_child(args, executable, preexec_fn, close_fds,
args = ['git', 'config', '--get', 'core.symlinks']
bufsize = -1
c2pread = 5
c2pwrite = Handle(2176)
close_fds = True
creationflags = 0
cwd = 'C:\\Users\\Administrator\\AppData\\Local\\Temp\\salt-tests-tmpdir'
encoding = None
env = None
errors = None
errread = -1
errwrite = Handle(2196)
executable = None
f = <_io.BufferedReader name=5>
p2cread = Handle(1984)
p2cwrite = -1
pass_fds = ()
preexec_fn = None
restore_signals = True
self = <subprocess.Popen object at 0x0000022B3012E400>
shell = False
start_new_session = False
startupinfo = None
stderr = None
stdin = None
stdout = -1
text = None
universal_newlines = None
c:\python38\lib\subprocess.py:1311: in _execute_child
hp, ht, pid, tid = _winapi.CreateProcess(executable, args,
E NotADirectoryError: [WinError 267] The directory name is invalid
args = 'git config --get core.symlinks'
attribute_list = {'handle_list': [1984, 2196, 2176]}
c2pread = 5
c2pwrite = Handle(2176)
close_fds = False
creationflags = 0
cwd = 'C:\\Users\\Administrator\\AppData\\Local\\Temp\\salt-tests-tmpdir'
env = None
errread = -1
errwrite = Handle(2196)
executable = None
handle_list = [1984, 2196, 2176]
have_handle_list = False
p2cread = Handle(1984)
p2cwrite = -1
pass_fds = ()
preexec_fn = None
self = <subprocess.Popen object at 0x0000022B3012E400>
shell = False
startupinfo = <subprocess.STARTUPINFO object at 0x0000022B2F5E54C0>
unused_restore_signals = True
unused_start_new_session = False
use_std_handles = True
```
Signed-off-by: Pedro Algarvio <[email protected]>
…s being tested
```
AssertionError: '/private/tmp/kitchen/testing/.nox/pytest-[4315 chars]…………' != '.…………………………………………………………………………………………………………[4052 chars]…………'
- /private/tmp/kitchen/testing/.nox/pytest-parametrized-3-crypto-none-transport-zeromq-coverage-true/lib/python3.9/site-packages/_distutils_hack/__init__.py:30: UserWarning: Setuptools is replacing distutils.
- warnings.warn("Setuptools is replacing distutils.")
```
Signed-off-by: Pedro Algarvio <[email protected]>
Signed-off-by: Pedro Algarvio <[email protected]>
Updated versionadded frmo 9999.9 to 3006.0 Co-authored-by: Nicholas Hughes <[email protected]>
Co-authored-by: Megan Wilhite <[email protected]>
Added the newline needed for salt documentation generation
Fixes saltstack#62239 Signed-off-by: Pedro Algarvio <[email protected]>
Signed-off-by: Pedro Algarvio <[email protected]>
Signed-off-by: Pedro Algarvio <[email protected]>
Signed-off-by: Pedro Algarvio <[email protected]>
Signed-off-by: Pedro Algarvio <[email protected]>
Signed-off-by: Pedro Algarvio <[email protected]>
Signed-off-by: Varun Sharma <[email protected]>
* Update versionadded from 3006 to 3005 * Add known issue about SSC 8.9.0 dependency * Add explanation for the issue * Update release candidate documentation * Add clarification per Shane's review * Add RHEL GPG key info * Revise topic per Murphy's review * Switch to the SaltStack ORG on quay.io Signed-off-by: Pedro Algarvio <[email protected]> * Update the salt pip executable to salt-pip * Fix pre-install and post-install scripts Make the date display in the logs properly * Add pyinstaller hook which pulls in all of salt and the standard library Signed-off-by: Pedro Algarvio <[email protected]> * Add changelog for saltstack#62383 which fixes saltstack#62362 Signed-off-by: Pedro Algarvio <[email protected]> * Windows search path is different Signed-off-by: Pedro Algarvio <[email protected]> * Salt should not do any logic to include/exclude requirements. That's pip's job. Refs saltstack#62386 Fixes saltstack#62392 Signed-off-by: Pedro Algarvio <[email protected]> Co-authored-by: Megan Wilhite <[email protected]> Co-authored-by: Alyssa Rock <[email protected]> Co-authored-by: Twangboy <[email protected]>
Version 3005rc2 Conflicts: * doc/topics/releases/releasecandidate.rst * tests/pytests/integration/modules/test_virt.py
Signed-off-by: Pedro Algarvio <[email protected]>
Update the bootstrap default URL and examples to current version
* add file.rmdir tests for original function * update file.rmdir exec module for recursive operation and verbose output * fixes saltstack#62178 add file.rmdir state * add older_than capability to file.rmdir exec and state modules * change test to use direct import of file module * Revert "change test to use direct import of file module" This reverts commit ff8c666. * revert previous test modification and add import to win_file * rename file.rmdir state to file.pruned
Hi! I'm your friendly PR bot!You might be wondering what I'm doing commenting here on your PR. Yes, as a matter of fact, I am... I'm just here to help us improve the documentation. I can't respond to Okay... so what do you do? I detect modules that are missing docstrings or "CLI Example" on existing docstrings! So what does that have to do with my PR? I noticed that in this PR there are some files changed that have some of these Okay, what are they? Well, my favorite, is that since you were making changes here I'm hoping that If I can, then what? Well, you can either add them to this PR or add them to another PR. Either way is fine! Well... what if I can't, or don't want to? That's also fine! We appreciate all contributions to the Salt Project. If you Whatever approach you decide to take, just drop a comment here letting us know! Detected Issues (click me)Check Known Missing Docstrings...........................................Failed - hook id: invoke - exit code: 1 Thanks again! |
1 similar comment
Hi! I'm your friendly PR bot!You might be wondering what I'm doing commenting here on your PR. Yes, as a matter of fact, I am... I'm just here to help us improve the documentation. I can't respond to Okay... so what do you do? I detect modules that are missing docstrings or "CLI Example" on existing docstrings! So what does that have to do with my PR? I noticed that in this PR there are some files changed that have some of these Okay, what are they? Well, my favorite, is that since you were making changes here I'm hoping that If I can, then what? Well, you can either add them to this PR or add them to another PR. Either way is fine! Well... what if I can't, or don't want to? That's also fine! We appreciate all contributions to the Salt Project. If you Whatever approach you decide to take, just drop a comment here letting us know! Detected Issues (click me)Check Known Missing Docstrings...........................................Failed - hook id: invoke - exit code: 1 Thanks again! |
|
There are a lot more commits here that are from the master branch and not just your changes. |
What does this PR do?
Update all platforms to use pycparser 2.21 or greater for Py 3.9 or higher. Earlier versions of pycparser made use of md5 which is no longer supported on RHEL 9 or Ubutnu 22.04 given they use Openssl v3.x which has dropped support for SHA-1 and MD5. Also pycparser v2.21 added support for Py 3.9 and 3.10.
What issues does this PR fix or reference?
Fixes: #62400
Previous Behavior
Fault due to missing sig on RHEL 9 with FIPS enabled, sig was created with md5 which is not available.
Simple command would cause fault
fips enabled with
fips-mode-setup --enableNew Behavior
No faults and command functions correctly
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.