Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix salt-ssh not detecting platform-python as a valid interpreter on EL8 #62236

Merged
merged 2 commits into from
Oct 12, 2022

Conversation

lastmikoi
Copy link
Contributor

What does this PR do?

This PR adds an additional (this time absolute) python path to salt-ssh's /bin/sh shim, to support deployments where the available interpreter is EL's platform-python (and thus mimic the salt RPM package behaviour).

This is a naive fix, I've originally thought about being able to use --python3-bin to steer salt-ssh into using the proper remote python, thus leaving the platform-python shenanigans to the user and their configuration choices, but that argument doesn't seem to be actually used by salt-ssh and my knowledge of the codebase isn't good enough to implement that change.

What issues does this PR fix or reference?

Fixes: #62235

Previous Behavior

salt-ssh would complain about Python 3 not being installed on a remote EL8 target even if salt is installed on the target.

New Behavior

salt-ssh finds the /usr/libexec/platform-python interpreter as an ultimate fallback to other more common python paths.

Merge requirements satisfied?

Commits signed with GPG?

Yes

@lastmikoi lastmikoi requested a review from a team as a code owner June 28, 2022 21:43
@lastmikoi lastmikoi requested review from twangboy and removed request for a team June 28, 2022 21:43
@Ch3LL Ch3LL merged commit 7957dc1 into saltstack:master Oct 12, 2022
@welcome
Copy link

welcome bot commented Oct 12, 2022

Congratulations on your first PR being merged! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] salt-ssh fails to find platform-python Python interpreter on EL8
4 participants