Add support for name, pkgs and diff_attr parameters to zypperpkg.upgrade()/yumpkg.upgrade()
#62033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agraul
force-pushed
the
zypper-upgrade-name-pkgs
branch
from
e2191a2
to
20ffffe
Compare
|
looks like there is a test failure that might be related to this change |
agraul
force-pushed
the
zypper-upgrade-name-pkgs
branch
from
20ffffe
to
e46ca5d
Compare
After rebasing the PR on top of the current master commit, I don't see the test failure locally anymore. Let's see if jenkins' test executions agree. |
Ch3LL
suggested changes
Sep 30, 2022
Ch3LL
added
Sulfur v3006.0
pkg_resource.format_pkg_list expects its `attr` argument to be either a list of attributes or the string "all" to indicate all available attributes should be used for formatting. Fixes: saltstack#62032
diff_attr works just like it does for pkg.install. Having the option to return additional attributes can remove the need for a follow-up list_pkgs call. Fixes: saltstack#62031
agraul
force-pushed
the
zypper-upgrade-name-pkgs
branch
from
e46ca5d
to
f8c99b0
Compare
Ch3LL
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add
diff_attrtoyumpkg.upgrade()and add it, together withnameandpkgs, tozypperpkg.upgrade().What issues does this PR fix or reference?
Fixes: #62030
Fixes: #62031
Fixes: #62032
Previous Behavior
nameandpkgsparameters are ignored inzypperpkg.upgrade(). Thediff_attrparameter is ignored by bothyumpkg.upgrade()andzypperpkg.upgrade()New Behavior
nameandpkgsparameters are used inzypperpkg.upgradeto only update/upgrade the specified package(s).diff_attris used byzypperpkg.upgrade()andyumpkg.upgrade()to output additional attributes.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes