-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding retry functionality when parallel is set to True #61631
Adding retry functionality when parallel is set to True #61631
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a question
Looks like the windows test failures are related to this PR |
…ntegration to functional tests. Converting unit test over to pytest.
Co-authored-by: Pedro Algarvio <[email protected]>
Co-authored-by: Pedro Algarvio <[email protected]>
Co-authored-by: Pedro Algarvio <[email protected]>
Co-authored-by: Pedro Algarvio <[email protected]>
Co-authored-by: Pedro Algarvio <[email protected]>
- Adds file.version that will get just the version - Adds file.version_details to get additional information - Adds tests - Adds changelog @amalaguti originally submitted a PR for this: saltstack#59770, but he has since deleted his branch. Recognizing his contribution here.
These tests cover the entire state, but are only concerned with the ret["result"] of the outputs. It would be a good idea to test other outputs as well - these tests could be modified to include assertions about the other parts of ret. (Obviously they would need to be slightly renamed. Maybe to `..._return_expected_ret`
Hi! I'm your friendly PR bot!You might be wondering what I'm doing commenting here on your PR. Yes, as a matter of fact, I am... I'm just here to help us improve the documentation. I can't respond to Okay... so what do you do? I detect modules that are missing docstrings or "CLI Example" on existing docstrings! So what does that have to do with my PR? I noticed that in this PR there are some files changed that have some of these Okay, what are they? Well, my favorite, is that since you were making changes here I'm hoping that If I can, then what? Well, you can either add them to this PR or add them to another PR. Either way is fine! Well... what if I can't, or don't want to? That's also fine! We appreciate all contributions to the Salt Project. If you Whatever approach you decide to take, just drop a comment here letting us know! Detected Issues (click me)Check Known Missing Docstrings...........................................Failed - hook id: invoke - duration: 1.35s - exit code: 1 Thanks again! |
is this a related failure? https://jenkins.saltproject.io/job/pr-macosx-catalina-x86_64-py3-pytest/job/PR-61631/22/testReport/ |
…ing_platform. Bump up duration for test_retry_option_success_parallel to 30 seconds to account for test running on Mac OS.
What does this PR do?
Making the retry state system feature available when parallel is set to True.
What issues does this PR fix or reference?
Fixes: #61630 #61439
Previous Behavior
When the retry options are set in a state and parallel is set to True, the job is rerun regardless of the original state results and the subsequent runs are not done in parallel.
New Behavior
Retry functionality is properly honored with
parallel: True
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.