Support macOS defaulting to spawn as the default multiprocessing method #57028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s0undt3ch
force-pushed
the
features/multiprocessing-method
branch
9 times, most recently
from
538c315 to
afb60db
Compare
ghost
requested review from
dwoz
added
Needs-Testcase
s0undt3ch
force-pushed
the
features/multiprocessing-method
branch
from
afb60db to
45b5f1e
Compare
s0undt3ch
added
ZRelease-Sodium
s0undt3ch
force-pushed
the
features/multiprocessing-method
branch
from
05a9e92 to
7aff97d
Compare
|
fixes #55847 |
s0undt3ch
force-pushed
the
features/multiprocessing-method
branch
from
7aff97d to
489658c
Compare
|
on behalf of the macOS folks thank you, thank you, thank you! |
|
this looks great. I know you mentioned that this isn't likely to hit Sodium but it would be awesome if it could. |
Signed-off-by: Pedro Algarvio <[email protected]>
Signed-off-by: Pedro Algarvio <[email protected]>
Signed-off-by: Pedro Algarvio <[email protected]>
Signed-off-by: Pedro Algarvio <[email protected]>
…to avoid ``NameError`` issues Signed-off-by: Pedro Algarvio <[email protected]>
Signed-off-by: Pedro Algarvio <[email protected]>
Signed-off-by: Pedro Algarvio <[email protected]>
Signed-off-by: Pedro Algarvio <[email protected]>
Signed-off-by: Pedro Algarvio <[email protected]>
Signed-off-by: Pedro Algarvio <[email protected]>
Signed-off-by: Pedro Algarvio <[email protected]>
…ues. Signed-off-by: Pedro Algarvio <[email protected]>
Signed-off-by: Pedro Algarvio <[email protected]>
…onal tests. Fixes saltstack#60819 Signed-off-by: Pedro Algarvio <[email protected]>
Fixes saltstack#57742 Signed-off-by: Pedro Algarvio <[email protected]>
Fixes saltstack#55847 Signed-off-by: Pedro Algarvio <[email protected]>
s0undt3ch
force-pushed
the
features/multiprocessing-method
branch
from
f17f6f0 to
0c67fb6
Compare
|
re-run full all |
twangboy
approved these changes
May 17, 2022
Ch3LL
approved these changes
May 20, 2022
garethgreenaway
approved these changes
May 20, 2022
|
🎆 |
|
You are all heroes <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Support macOS defaulting to spawn as the default multiprocessing method
What issues does this PR fix or reference?
We were previously forcing macOS to use fork instead of the the default spawn method, we fix that in this PR
Fixes #55847
Fixes #57742
Refs #61045
Previous Behavior
We used the "fork" method for macOS
New Behavior
We use the default spawn method for macOS
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes