-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring #51372 to Master branch #55817
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #55817 +/- ##
===========================================
+ Coverage 18.77% 20.32% +1.56%
===========================================
Files 827 37 -790
Lines 176462 7402 -169060
Branches 37977 1723 -36254
===========================================
- Hits 33110 1504 -31606
+ Misses 140702 5801 -134901
+ Partials 2650 97 -2553
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #55817 +/- ##
===========================================
+ Coverage 18.77% 20.32% +1.56%
===========================================
Files 827 37 -790
Lines 176462 7402 -169060
Branches 37977 1723 -36254
===========================================
- Hits 33110 1504 -31606
+ Misses 140702 5801 -134901
+ Partials 2650 97 -2553
|
ghost
requested a review
from DmitryKuzmenko
January 8, 2020 21:49
rares-pop
reviewed
Jan 9, 2020
rares-pop
reviewed
Jan 9, 2020
rares-pop
reviewed
Jan 9, 2020
rares-pop
reviewed
Jan 9, 2020
twangboy
added
ZRELEASED - 2017.7
retired label
ZRELEASED - Neon
retired label
and removed
ZRELEASED - 2017.7
retired label
labels
Jan 11, 2020
rares-pop
approved these changes
Jan 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
dwoz
approved these changes
Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Brings #51372 to master
Tests written?
Yes
Commits signed with GPG?
Yes