Fix CherryPy CORS on Python3 #55207
Merged
Fix CherryPy CORS on Python3 #55207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
niflostancu
force-pushed
the
fix-cherrypy-cors
branch
from
912268d
to
fc401ca
Compare
niflostancu
force-pushed
the
fix-cherrypy-cors
branch
from
fc401ca
to
213b1ea
Compare
dwoz
approved these changes
Dec 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a salt_cherrypy bug on Python3 (500 Internal Server Error).
What issues does this PR fix or reference?
Fixes #55087
Tests written?
I created a unit test for the cors_tool that verifies whether CORS OPTIONS request returns HTTP 200 OK. Test failed before the second commit which fixes the bug.
Commits signed with GPG?
No (no backdoors included, trivial to verify :D)