[master] Add 'ppc64le' as a valid RPM package architecture #55150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
|
@meaksh thanks for porting this! This is one of those places our 3-review exception exists for, as the unit test isn't terribly meaningful. If you want to remove the test here, we can get the three votes & merged. |
|
I went ahead and removed the extra tests, we should be able to get this approved and merged today. |
waynew
approved these changes
Nov 13, 2019
s0undt3ch
approved these changes
Nov 13, 2019
|
@waynew thanks for pushing this ahead! 👍 |
DmitryKuzmenko
approved these changes
Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR ports #53237 to
masterbranch and also adds unit test for it.Tests written?
Yes
Commits signed with GPG?
Yes