(Backport 51929, 51954) lvm: be quiet when a pv, lv or vg is not expected #54997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aplanas
changed the title
dwoz
approved these changes
Nov 14, 2019
ghost
requested a review
from When we try to create a new pv, lv or vg, there is a chance that is not present in the system. Also when we want to remove it, we expect that is absent and the end of the operation. This patch hide the error messages from pvdisplay, lvdisplay and vgdisplay commands in those cases. (cherry picked from commit 922d192)
The LVM module behaves like a state when doing a pvcreate and a pvremove, checking the previous and last state. We do not expect to have a physical volume before creating it, or after removing it. This patch pass the 'quiet' parameter into pvdisplay to hide the expected error in those cases. (cherry picked from commit 46b4577)
aplanas
force-pushed
the
backport_51929
branch
from
85ae795
to
8efa40b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When we try to create a new pv, lv or vg, there is a chance that
is not present in the system. Also when we want to remove it, we
expect that is absent and the end of the operation.
This patch hide the error messages from pvdisplay, lvdisplay and
vgdisplay commands in those cases.
Tests written?
Yes
(backport #51929 and #51954, already merged in develop)