Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] salt.features should not be used, at all #65951

Closed
s0undt3ch opened this issue Jan 30, 2024 · 1 comment
Closed

[BUG] salt.features should not be used, at all #65951

s0undt3ch opened this issue Jan 30, 2024 · 1 comment
Assignees
Labels
Bug broken, incorrect, or confusing behavior needs-triage

Comments

@s0undt3ch
Copy link
Collaborator

Description
To provide an easier way to check feature flags, salt.features was added in #58238

This implementation relies on the features dictionary to be populated from the config dictionary.

  1. The features dictionary is instantiated on salt.utils.parsers, so, any configuration instantiation at runtime(for examples, separate process) will not instantiate features.
  2. If the features dictionary is populated from the configuration, why add another layer? Just check the configuration.
@s0undt3ch s0undt3ch added Bug broken, incorrect, or confusing behavior needs-triage labels Jan 30, 2024
Copy link

welcome bot commented Jan 30, 2024

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@s0undt3ch s0undt3ch self-assigned this Jan 30, 2024
@s0undt3ch s0undt3ch added this to the Sulfur v3006.6 milestone Jan 30, 2024
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue Jan 30, 2024
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior needs-triage
Projects
None yet
Development

No branches or pull requests

1 participant