Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor type-o in salt.modules.dpkg_lowpkg._get_pkg_info() when calling cmd.run_all #54907

Closed
arizvisa opened this issue Oct 6, 2019 · 6 comments · Fixed by #58610
Closed

Minor type-o in salt.modules.dpkg_lowpkg._get_pkg_info() when calling cmd.run_all #54907

arizvisa opened this issue Oct 6, 2019 · 6 comments · Fixed by #58610
Labels
Bug broken, incorrect, or confusing behavior good first issue good for someone new to salt severity-low 4th level, cosemtic problems, work around exists
Milestone
Approved

Comments

@arizvisa
Copy link
Contributor

arizvisa commented Oct 6, 2019

Description of Issue

This is pretty minor and should get low priority, but when _get_pkg_info from salt.modules.dpkg_lowpkg calls cmd.run_all, the original author mistakenly passed the parameter python_chell=False.

This should probably be python_shell=False, but since the python_shell parameter for cmd.run_all is None by default, the misspelling doesn't directly affect anything.

Setup

Found while tracking down some other issue.

Steps to Reproduce Issue

File and line-number is in salt/modules/dpkg_lowpkg.py:239 which is linked at
https://github.com/saltstack/salt/blob/develop/salt/modules/dpkg_lowpkg.py#L329

Versions Report

Looks like it was introduced by commit 1aa8a85 which is from v2016.3.
@garethgreenaway garethgreenaway assigned waynew and dwoz and unassigned waynew Oct 14, 2019
@dwoz dwoz added Bug broken, incorrect, or confusing behavior Low-Hanging Fruit P3 Priority 3 severity-low 4th level, cosemtic problems, work around exists and removed needs-triage labels Oct 14, 2019
@dwoz dwoz added this to the Approved milestone Oct 14, 2019
@dwoz dwoz removed their assignment Oct 14, 2019
@Horiol Horiol mentioned this issue Oct 23, 2019
Closed
@jgphilpott
Copy link

:)

@stale
Copy link

stale bot commented Jan 9, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

@stale stale bot added the stale label Jan 9, 2020
@arizvisa
Copy link
Contributor Author

arizvisa commented Jan 9, 2020

This type-o hasn't been fixed yet. The PR is there, but it hasn't been merged.

@stale
Copy link

stale bot commented Jan 9, 2020

Thank you for updating this issue. It is no longer marked as stale.

@stale stale bot removed the stale label Jan 9, 2020
@sagetherage sagetherage added good first issue good for someone new to salt and removed Low-Hanging Fruit labels May 23, 2020
@sagetherage sagetherage removed the P3 Priority 3 label Jun 3, 2020
@spencer-burke
Copy link
Contributor

Hello, I will take care of this typo.

spencer-burke added a commit to spencer-burke/salt that referenced this issue Oct 1, 2020
@spencer-burke
Fix Minor type-o in salt.modules.dpkg_lowpkg._get_pkg_info() when cal…
f9e31ff 
…ling cmd.run_all

Fixes saltstack#54907

This change simply fixes the typo found within the module "dpkg_lowpkg".
@spencer-burke spencer-burke mentioned this issue Oct 1, 2020
Merged
3 tasks
@arizvisa
Copy link
Contributor Author

arizvisa commented Oct 2, 2020

good luck. I've tried to fix type-o's before and they've made me write unit tests for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug broken, incorrect, or confusing behavior good first issue good for someone new to salt severity-low 4th level, cosemtic problems, work around exists
Projects
None yet
Milestone
Approved
Development

Successfully merging a pull request may close this issue.

Fix Minor type-o in salt.modules.dpkg_lowpkg._get_pkg_info() when cal… spencer-burke/salt
7 participants
@waynew @garethgreenaway @dwoz @arizvisa @jgphilpott @spencer-burke @sagetherage