Skip to content

Commit

Permalink
Remove un-needed method
Browse files Browse the repository at this point in the history
  • Loading branch information
dwoz authored and garethgreenaway committed Sep 15, 2021
1 parent 7af10f2 commit d5a16a1
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 28 deletions.
14 changes: 5 additions & 9 deletions salt/scripts.py
Original file line number Diff line number Diff line change
Expand Up @@ -446,15 +446,11 @@ def salt_call():
except ImportError:
zeromq = None

try:
if "" in sys.path:
sys.path.remove("")
client = salt.cli.call.SaltCall()
_install_signal_handlers(client)
client.run()
finally:
if zeromq is not None:
zeromq.AsyncZeroMQReqChannel.force_close_all_instances()
if "" in sys.path:
sys.path.remove("")
client = salt.cli.call.SaltCall()
_install_signal_handlers(client)
client.run()


def salt_run():
Expand Down
7 changes: 0 additions & 7 deletions salt/transport/tcp.py
Original file line number Diff line number Diff line change
Expand Up @@ -213,13 +213,6 @@ class AsyncTCPReqChannel(salt.transport.client.ReqChannel):


@classmethod
def force_close_all_instances(cls):
"""
Will force close all instances
:return: None
"""
pass

def __init__(self, opts, **kwargs):
self.opts = dict(opts)

Expand Down
12 changes: 0 additions & 12 deletions salt/transport/zeromq.py
Original file line number Diff line number Diff line change
Expand Up @@ -138,18 +138,6 @@ class AsyncZeroMQReqChannel(salt.transport.client.ReqChannel):
"close",
]

@classmethod
def force_close_all_instances(cls):
"""
Will force close all instances
ZMQ can hang on quit if left to deconstruct on its own.
This because is deconstructs out of order.
:return: None
"""
pass

def __init__(self, opts, **kwargs):
self.opts = dict(opts)
self.ttype = "zeromq"
Expand Down

0 comments on commit d5a16a1

Please sign in to comment.