Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix process shutdown on Android #51

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Fix process shutdown on Android #51

merged 1 commit into from
Oct 17, 2024

Conversation

dead10ck
Copy link
Contributor

@dead10ck dead10ck commented Oct 12, 2024 •
edited
Loading

  • fix: handle process shutdown with limited permissions

Certain platforms like Android do not have permission to list all child processes. In this instance, just continue

@dead10ck dead10ck requested a review from a team as a code owner October 12, 2024 14:24
@dead10ck dead10ck requested a review from felippeb October 12, 2024 14:24
@dmurphy18 dmurphy18 assigned dmurphy18 and unassigned dmurphy18 Oct 14, 2024
@dmurphy18 dmurphy18 self-requested a review October 14, 2024 16:37
dmurphy18
dmurphy18 requested changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@dmurphy18 dmurphy18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to rebase against current, psutil is already updated to version 6.0.0. (done a few week sback)
Then retest your changes, always best to ensure rebased against latest before submitting a PR

@dead10ck
fix: handle process shutdown with limited permissions
96c4965 
Certain platforms like Android do not have permission to list all child
processes. In this instance, just continue
@dead10ck dead10ck force-pushed the fix/child-processes branch from ebf3a7a to 96c4965 Compare October 17, 2024 02:35
@dead10ck
Copy link
Contributor Author

Done

@dmurphy18 dmurphy18 removed the request for review from felippeb October 17, 2024 16:16
@dmurphy18 dmurphy18 merged commit fcf6311 into saltstack:main Oct 17, 2024
29 checks passed
@dmurphy18
Copy link
Collaborator

Merged the PR by hand into the main branch, due to to the docs/readthedocs.org:pytest-shell-utilities requirement is met on https://readthedocs.org/projects/pytest-shell-utilities/builds/, but the passed response appears to not have made it back to Github.

@dmurphy18
Copy link
Collaborator

@dead10ck Just released version 1.9.4 with your fix for pytest-shell-utilities

@dead10ck
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmurphy18 dmurphy18 dmurphy18 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dead10ck @dmurphy18