Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Skip test when the GLIBC race conditions are met, instead of failing" #16

Merged
merged 1 commit into from
May 19, 2022

Conversation

s0undt3ch
Copy link
Contributor

This reverts commit f79aba3, it wasn't
the right fix. The right fix can be seen in saltstack/salt#62078

@s0undt3ch s0undt3ch requested a review from a team as a code owner May 19, 2022 06:16
@s0undt3ch s0undt3ch requested a review from Ch3LL May 19, 2022 06:16
…failing."

This reverts commit f79aba3, it wasn't
the right fix. The right fix can be seen in saltstack/salt#62078
@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #16 (8cd2878) into main (96b291f) will decrease coverage by 1.75%.
The diff coverage is n/a.

❗ Current head 8cd2878 differs from pull request most recent head 539ebcd. Consider uploading reports for the commit 539ebcd to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   86.70%   84.96%   -1.74%     
==========================================
  Files          31       31              
  Lines        2278     2213      -65     
  Branches      341      284      -57     
==========================================
- Hits         1975     1880      -95     
- Misses        228      250      +22     
- Partials       75       83       +8     
Flag Coverage Δ
src 80.11% <ø> (-1.81%) ⬇️
tests 95.29% <ø> (-0.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pytestshellutils/downgraded/shell.py 81.20% <ø> (+0.99%) ⬆️
src/pytestshellutils/shell.py 87.66% <ø> (-0.82%) ⬇️
tests/functional/shell/test_subprocess.py 100.00% <ø> (ø)
src/pytestshellutils/utils/processes.py 66.88% <0.00%> (-18.83%) ⬇️
src/pytestshellutils/__init__.py 90.00% <0.00%> (-3.33%) ⬇️
tests/functional/shell/test_daemon.py 84.80% <0.00%> (-2.99%) ⬇️
src/pytestshellutils/customtypes.py 95.46% <0.00%> (-0.19%) ⬇️
tests/conftest.py 100.00% <0.00%> (ø)
tests/unit/customtypes/test_callback.py 100.00% <0.00%> (ø)
... and 4 more

@s0undt3ch s0undt3ch merged commit ccdd73b into saltstack:main May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants