feat(config): salt has a module to serialize to TOML

[baby-gnu]

The use of a custom module is not required anymore since salt 2017 support ended 2019-12-31.

• telegraf/files/default/telegraf.tmpl.jinja: replace custom module call with salt['slsutil.serialize'].

BREAKING CHANGE: salt['slsutil.serialize'] requires salt >= 2018.3

---

[baby-gnu]

It looks like on Centos, the salt-minion does not find the newly installed toml python3 library.

For openSUSE, this is an infrastructure problem.

[baby-gnu]

It looks like on Centos, the salt-minion does not find the newly installed toml python3 library.

I found the issue in map.jinja, the python3-toml package was installed for the builtin module but Centos 8 has a python3-pytoml.

[n-rodriguez]

LGTM

[myii]

@baby-gnu Nice work, just a minor change requested for now.

[myii]

Bit short on time but a few more comments:

• saltstack/salt@e6e442c
  • toml serializer was introduced in 2018.3
• saltstack/salt@3898ab2
  • But was only added to the docs for 3000
• https://travis-ci.org/myii/telegraf-formula/builds/659478502
  • Some instances that may be worth considering

---

Thanks for the review, @n-rodriguez.

[myii]

• toml serializer was introduced in 2018.3

@baby-gnu It would be worth adding this as a BREAKING CHANGE message as well. Two reasons why the minimum version supported is 2018.3.

[baby-gnu]

• https://travis-ci.org/myii/telegraf-formula/builds/659478502
  • Some instances that may be worth considering

I think they should be managed in a separate pull request with a rework of the map.jinja and the handling of the python library.

[baby-gnu]

We should note that maybe someday the toml library used will change : saltstack/salt#56323

[myii]

@baby-gnu Would you mind including this commit to finalise this PR?

• eole@db7098e

I tried to push this on directly on top of this PR but didn't have the permissions to do so. It appears that Allow edits from maintainers is disabled.

[baby-gnu]

Note that there is no python toml library on amazonlinux

./bin/kitchen exec default-amazonlinux-2-master-py3 -c 'sudo yum search toml'
-----> Execute command on default-amazonlinux-2-master-py3.
       Failed to set locale, defaulting to C
       Modules compl?mentaires charg?s?: ovl, priorities
       Attention : aucune correspondance trouvée pour : toml
       No matches found

[myii]

@baby-gnu Thanks for adding the commit.

Note that there is no python toml library on amazonlinux

Actually, there is a package available by adding the EPEL repo:

• https://dl.fedoraproject.org/pub/epel/7/x86_64/Packages/p/
  • python36-pytoml-0.1.20-1.el7.noarch.rpm

I'm sure it would be possible to get amazonlinux working by adding this repo. There are examples of doing this inline in other formulas, which I could dig out if required.

[saltstack-formulas-travis]

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[myii]

@baby-gnu Re: amazonlinux-2, similar to the change made to the openvpn-formula.

[baby-gnu]

Thanks @myii, as I'm starting to use the telegraf-formula, I think I can work a little bit more on it. But amazonlinux is not my priority for now.