Fix redis:lookup
regression (fixes #75)
#76
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've already been submitting
map.jinja
PRs today:apache:lookup
regression apache-formula#252salt:lookup
regression salt-formula#396Noticed issue #75 here was effectively the same issue re:
lookup
issues:The structure of this fix has been discussed in detail, particularly in the
apache-formula
pull.I've tested before and after this PR, with the following
lookup
values, almost identical topillar.example
except forovercommit_memory
, in order to test for #75:The diff of
map.jinja
rendering before and after this PR:lookup
being merged in as well.Update: logging CI problems.
ubuntu-1804
:Job for redis-server.service failed because a timeout was exceeded.
centos-7
:No package redis-server available.
redis
oncentos-7
, notredis-server
.