Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(network manager networks): make python code verson agnostic #157

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alxwr
Copy link
Member

@alxwr alxwr commented Aug 21, 2023

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Support Python 3 in the connection.jinja template.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

----------                                                                                                                                 
          ID: /etc/NetworkManager/system-connections/server_udp                                                                              
    Function: file.managed                                                                                                                 
      Result: True                                                                                                                         
     Comment: File /etc/NetworkManager/system-connections/server_udp updated                                                                 
     Started: 18:19:17.635143                                                                                                              
    Duration: 508.104 ms                                                                                                                   
     Changes:                                                                                                                              
              ----------                                                                                                                   
              diff:                                                                                                                        
                  New file
----------
          ID: network_manager_connection_reload
    Function: cmd.run
        Name: /usr/bin/nmcli connection reload
      Result: True
     Comment: Command "/usr/bin/nmcli connection reload" run
     Started: 18:19:26.420264
    Duration: 51.624 ms
     Changes:   
              ----------
              pid:
                  2271118
              retcode:
                  0
              stderr:
              stdout:

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@alxwr alxwr requested a review from dafyddj as a code owner August 21, 2023 16:20
@alxwr alxwr self-assigned this Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant