Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Promote 'ng' states #35

Closed
daks opened this issue Nov 22, 2019 · 12 comments · Fixed by #40
Closed

[FEATURE] Promote 'ng' states #35

daks opened this issue Nov 22, 2019 · 12 comments · Fixed by #40
Labels
enhancement released

Comments

@daks
Copy link
Member

daks commented Nov 22, 2019 •
edited
Loading

Is your feature request related to a problem?

No

Describe the solution you'd like

Now that this formula has semantic versioning, I think it's time to start deprecating fail2ban.ng and then promote it to fail2ban which means remove all legacy code.

Steps:

  • start indicating that fail2ban.ng is deprecated
  • move fail2ban.ng states to fail2ban

Describe alternatives you've considered

none

Additional context

This has already been done for nginx-formula and others (but I don't know which).
@myii
Copy link
Member

myii commented Nov 22, 2019

@daks Sounds good, these are the current deprecation steps, from previous conversions:

myii added a commit to myii/fail2ban-formula that referenced this issue Nov 26, 2019
@myii
feat(deprecated.sls): prepare warning state for ng promotion (salts…
4c702bc 
…tack-formulas#35)
@myii
Copy link
Member

myii commented Nov 26, 2019

@daks Stage one and two out of three provided in #36.

@myii myii mentioned this issue Nov 26, 2019
Merged
19 tasks
myii added a commit to myii/ssf-formula that referenced this issue Nov 26, 2019
@myii
feat(fail2ban): add notification about upcoming ng promotion
3373025 
* saltstack-formulas/fail2ban-formula#34 (comment)
* saltstack-formulas/fail2ban-formula#35
@myii myii mentioned this issue Nov 26, 2019
Merged
myii added a commit to myii/ssf-formula that referenced this issue Nov 26, 2019
@myii
feat(fail2ban): add notification about upcoming ng promotion
0447603 
* saltstack-formulas/fail2ban-formula#34 (comment)
* saltstack-formulas/fail2ban-formula#35
saltstack-formulas-travis pushed a commit that referenced this issue Nov 27, 2019
@semantic-release-bot
chore(release): 0.17.0 [skip ci]
208277d 
# [0.17.0](v0.16.3...v0.17.0) (2019-11-27)

### Bug Fixes

* **release.config.js:** use full commit hash in commit link [skip ci] ([37439c8](37439c8))

### Continuous Integration

* **kitchen:** use `debian-10-master-py3` instead of `develop` [skip ci] ([14629b9](14629b9))
* **kitchen:** use `develop` image until `master` is ready (`amazonlinux`) [skip ci] ([6652ff9](6652ff9))
* **kitchen+travis:** upgrade matrix after `2019.2.2` release [skip ci] ([9968b09](9968b09))
* **travis:** apply changes from build config validation [skip ci] ([885c517](885c517))
* **travis:** opt-in to `dpl v2` to complete build config validation [skip ci] ([5112d76](5112d76))
* **travis:** run `shellcheck` during lint job ([527cf1e](527cf1e))
* **travis:** update `salt-lint` config for `v0.0.10` [skip ci] ([52eb62c](52eb62c))
* **travis:** use build config validation (beta) [skip ci] ([2ae5e8c](2ae5e8c))

### Documentation

* **contributing:** remove to use org-level file instead [skip ci] ([2688f64](2688f64))
* **readme:** update link to `CONTRIBUTING` [skip ci] ([37c0dd1](37c0dd1))

### Features

* update deprecation version number in `semantic-release` run ([11d748a](11d748a))
* **deprecated.sls:** prepare warning state for `ng` promotion ([#35](#35)) ([4c702bc](4c702bc))
* **deprecation:** include `ng` promotion warning to all state files ([4348b59](4348b59))

### Performance Improvements

* **travis:** improve `salt-lint` invocation [skip ci] ([5a14047](5a14047))
myii added a commit to myii/ssf-formula that referenced this issue Nov 27, 2019
@myii
feat(fail2ban): add notification about upcoming ng promotion
8c91168 
* saltstack-formulas/fail2ban-formula#34 (comment)
* saltstack-formulas/fail2ban-formula#35
@myii myii mentioned this issue Jan 9, 2020
Merged
19 tasks
@myii
Copy link
Member

myii commented Jan 10, 2020

We've got a significant blocker before this can be completed. There are a number of errors when running the ng states, affecting all platforms:

@daks
Copy link
Member Author

daks commented Jan 10, 2020

@myii Do you mean those ng states are broken? Hum... that's not good, and I don't know them, we are still using the legacy ones.

@myii
Copy link
Member

myii commented Jan 10, 2020

@Irsute Good catch; while using the pillar.example file is intended, commenting out those lines should help so that it uses the default template. Running it again to see how far we progress:

@myii
Copy link
Member

myii commented Jan 10, 2020 •
edited
Loading

OK, that's better. The ones that are broken are probably due to configuration issues. However, looking at the debug output, I've identified another bug:

fail2ban-formula/fail2ban/ng/map.jinja

Line 23 in d41fe3f

}, merge=salt['pillar.get']('fail2ban:lookup')) %}

This is supposed to be fail2ban:ng:lookup, so I'm running it again, mainly to make sure that ignoreip is used in the right file:

@myii
Copy link
Member

myii commented Jan 10, 2020

And there you have it, fixed the configuration from the ng:lookup and now all platforms are passing!

@Irsute
Copy link
Contributor

Irsute commented Jan 10, 2020

a big thanks @myii ,
so in good way to promote ng ^^

@myii
Copy link
Member

myii commented Jan 10, 2020 •
edited
Loading

@Irsute So the next few steps:

  • I'm going to test ignoreip in multiple jails, to make sure it is working properly.
  • I'll submit a new PR to run Kitchen for fail2ban.ng rather than fail2ban, including fixing the lookup bug mentioned above. -- ci(kitchen): use fail2ban.ng in state_top #39.
  • I'll ask you to modify your PR so that it can also be merged.

After that, the next stages of completing this issue can be looked at.

@Irsute
Copy link
Contributor

Irsute commented Jan 10, 2020

PR is updated

myii added a commit to myii/ssf-formula that referenced this issue Jan 10, 2020
@myii
feat(fail2ban): use fail2ban.ng in Kitchen
5a5df71 
* saltstack-formulas/fail2ban-formula#35 (comment)
@myii myii mentioned this issue Jan 10, 2020
Merged
myii added a commit to myii/fail2ban-formula that referenced this issue Jan 10, 2020
@myii
ci(kitchen): use fail2ban.ng in state_top (saltstack-formulas#35)
b826d28 
* Semi-automated using myii/ssf-formula#118
* Fix `ng:lookup` to use values that actually work
@myii myii mentioned this issue Jan 10, 2020
Merged
19 tasks
myii added a commit to myii/fail2ban-formula that referenced this issue Jan 10, 2020
@myii
ci(kitchen): use fail2ban.ng in state_top (saltstack-formulas#35)
10b403f 
* Semi-automated using myii/ssf-formula#118
* Fix `ng:lookup` to use values that actually work
saltstack-formulas-travis pushed a commit that referenced this issue Jan 10, 2020
@semantic-release-bot
chore(release): 0.17.2 [skip ci]
7a35761 
## [0.17.2](v0.17.1...v0.17.2) (2020-01-10)

### Bug Fixes

* **ng/map.jinja:** use `ng:lookup` rather than `lookup` ([cb76484](cb76484))

### Continuous Integration

* **kitchen:** use `fail2ban.ng` in `state_top` ([#35](#35)) ([10b403f](10b403f))
myii pushed a commit to myii/ssf-formula that referenced this issue Jan 11, 2020
@semantic-release-bot
chore(release): 1.74.0 [skip ci]
2a6de48 
# [1.74.0](v1.73.0...v1.74.0) (2020-01-11)

### Features

* **fail2ban:** use `fail2ban.ng` in Kitchen ([5a5df71](5a5df71)), closes [/github.com/saltstack-formulas/fail2ban-formula/issues/35#issuecomment-573162677](https://github.com//github.com/saltstack-formulas/fail2ban-formula/issues/35/issues/issuecomment-573162677)
myii added a commit to myii/fail2ban-formula that referenced this issue Jan 11, 2020
@myii
feat: promote ng
74d9615 
* Close saltstack-formulas#34
* Close saltstack-formulas#35
myii added a commit to myii/fail2ban-formula that referenced this issue Jan 11, 2020
@myii
feat: promote ng
fcaf743 
* Close saltstack-formulas#34
* Close saltstack-formulas#35
@myii myii mentioned this issue Jan 11, 2020
Merged
19 tasks
myii added a commit to myii/fail2ban-formula that referenced this issue Jan 11, 2020
@myii
feat: promote ng
564990c 
* Close saltstack-formulas#34
* Close saltstack-formulas#35

BREAKING CHANGE: all previous `fail2ban` based configurations must be
reviewed; `fail2ban.ng` usage must be promoted to `fail2ban` and any
uses of the original `fail2ban` will have to be converted.
myii added a commit to myii/fail2ban-formula that referenced this issue Jan 11, 2020
@myii
feat: promote ng
fb1ae56 
* Semi-automated using myii/ssf-formula#119
* Close saltstack-formulas#34
* Close saltstack-formulas#35

BREAKING CHANGE: all previous `fail2ban` based configurations must be
reviewed; `fail2ban.ng` usage must be promoted to `fail2ban` and any
uses of the original `fail2ban` will have to be converted.
@daks
Copy link
Member Author

daks commented Jan 13, 2020

good job @myii

@myii myii closed this as completed in #40 Jan 13, 2020
saltstack-formulas-travis pushed a commit that referenced this issue Jan 13, 2020
@semantic-release-bot
chore(release): 1.0.0 [skip ci]
8b80e2a 
# [1.0.0](v0.17.2...v1.0.0) (2020-01-13)

### Features

* promote `ng` ([fb1ae56](fb1ae56)), closes [#34](#34) [#35](#35)

### BREAKING CHANGES

* all previous `fail2ban` based configurations must be
reviewed; `fail2ban.ng` usage must be promoted to `fail2ban` and any
uses of the original `fail2ban` will have to be converted.
@saltstack-formulas-travis
Copy link

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: promote ng myii/fail2ban-formula
4 participants
@daks @myii @Irsute @saltstack-formulas-travis