Better error logging #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-kaspar
suggested changes
May 19, 2017
lib/db.js
Outdated
| const stringStart = string.substring(0, endLineWrapPos); | ||
| const stringEnd = string.substr(endLineWrapPos); | ||
| const startLineWrapPos = stringStart.lastIndexOf('\n') + 1; | ||
| const padding = ' '.repeat(position - Math.max(startLineWrapPos, 0) - 1); |
There was a problem hiding this comment.
position is guaranteed to be at least 0
startLineWrapPos is also guaranteed to be at least 0 (so the with Math.max doesn't seem to make sense?)
assuming position >= startLineWrapPos.
so overall the parameter passed to report is at least (0 - 0 - 1) = (-1).
' '.repeat(-1) throws exception both in browser and in node.js
so I think the Math.max test should be around all of that, i.e.
' '.repeat(Math.max(position - startLineWrapPos - 1, 0))
... or did I miss anything here?
There was a problem hiding this comment.
👍
Position should be >=1 because SQL indexing starts with 1, and Math.max is really redundant.
dolezel
commented
May 22, 2017
lib/db.js
Outdated
| @@ -38,13 +38,13 @@ export default (connection_string) => { | |||
| ) | |||
| .catch(err => { | |||
| const { message, position } = err; | |||
| if (message && position >= 0) { | |||
| if (message && position >= 1) { | |||
| const endLineWrapIndexOf = string.indexOf('\n', position); | |||
| const endLineWrapPos = endLineWrapIndexOf >= 0 ? endLineWrapIndexOf : string.length; | |||
| const stringStart = string.substring(0, endLineWrapPos); | |||
| const stringEnd = string.substr(endLineWrapPos); | |||
| const startLineWrapPos = stringStart.lastIndexOf('\n') + 1; | |||
There was a problem hiding this comment.
It is
const startLineIndexOf = stringStart.lastIndexOf('\n');
const startLineWrapPos = startLineIndexOf >= 0 ? startLineIndexOf + 1 : 0;
Because we want to start AFTER \n or on first character...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.