Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-821: Put migrations table check inside lock #830

Merged
merged 2 commits into from
Sep 20, 2021
Merged

gh-821: Put migrations table check inside lock #830

merged 2 commits into from
Sep 20, 2021

Conversation

littlewhywhat
Copy link
Contributor

@littlewhywhat littlewhywhat commented Sep 14, 2021 •
edited
Loading

seems like no harm to do it - unless I am missing smth.

Yet it can solve the raised issue.

Solves gh-821

@littlewhywhat littlewhywhat linked an issue Sep 14, 2021 that may be closed by this pull request
Migrations table is created outside lock #821
Closed
goce-cz
goce-cz approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@goce-cz goce-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any eventual problem with my short-sighted eyes. I'd even go further and acquire the lock prior the schema creation.

@littlewhywhat littlewhywhat merged commit 1cd2ee9 into master Sep 20, 2021
@Shinigami92 Shinigami92 deleted the gh-821-put-migrations-table-inside-lock branch March 4, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@goce-cz goce-cz Awaiting requested review from goce-cz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrations table is created outside lock
3 participants
@littlewhywhat @Shinigami92 @goce-cz