Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not return just an array with a boolean, but an array containing an object with a
lockObtained
property. With the existing implementation every caller would think that it acquired the lock and proceed with migrations. Easily reproducible by just programmatically calling the runner multiple times in aPromise.all
, and having the migrations add something with a unique constraint (and index name for example):This PR also makes sure that the lock is released. When testing this, I found that once the first runner ran, the next ones never managed to acquire the lock on subsequent retries.