Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored types #519

Merged
merged 2 commits into from
Nov 25, 2019
Merged

Refactored types #519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fc7d5e
Refactored types
dolezel Nov 25, 2019
7fbed23
Fixed import
dolezel Nov 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,7 @@ module.exports = {
'no-underscore-dangle': 0,
'security/detect-object-injection': 0,
'@typescript-eslint/explicit-function-return-type': 0,
'import/no-cycle': 0,
'@typescript-eslint/no-explicit-any': 0,
'import/no-duplicates': 0,
},
overrides: [
{
Expand Down
4 changes: 1 addition & 3 deletions bin/node-pg-migrate
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@ const util = require('util')
const path = require('path')
const yargs = require('yargs')
const ConnectionParameters = require('pg/lib/connection-parameters')
const migrationRunner = require('../index')

const { Migration } = migrationRunner
const { default: migrationRunner, Migration } = require('../dist')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool ✨
Didn't know that this is possible

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is, that typescript does not produce commonjs compatible default export.
microsoft/TypeScript#2719
But as the es6 is future 🙏 and many other packages switched to using es6 exports/imports, I will not try to fix it...


process.on('uncaughtException', err => {
console.log(err.stack)
Expand Down
Loading