Migration tests #221
Merged
Migration tests #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-kaspar
approved these changes
Mar 23, 2018
| }); | ||
| const options = (direction, _count, _timestamp) => { | ||
| const count = _count === undefined ? numMigrations : _count; | ||
| const timestamp = _timestamp === undefined ? TIMESTAMP : _timestamp; |
There was a problem hiding this comment.
why falling back to older node.js?
There was a problem hiding this comment.
I want to still support node 4 as it is still in maintenance (until next month ... https://github.com/nodejs/Release#release-schedule)
dolezel
force-pushed
the
migration_tests
branch
from
2d4bac6 to
53974e8
Compare
dolezel
added a commit
that referenced
this pull request
Mar 23, 2018
* Table tests * Fixing script for node 4 * Fixes * More tests and fixes * More test - constraints * More test - indexes * More test - types * More test - roles * More test - functions * More test - triggers * More test - domains * Fixes, more test - sequence * More test - operators * More test - policies * Alter role test
dolezel
added a commit
that referenced
this pull request
Mar 23, 2018
* Table tests * Fixing script for node 4 * Fixes * More tests and fixes * More test - constraints * More test - indexes * More test - types * More test - roles * More test - functions * More test - triggers * More test - domains * Fixes, more test - sequence * More test - operators * More test - policies * Alter role test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.