Support object with schema and table name in more places #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolezel
suggested changes
Aug 25, 2017
lib/operations/tables.js
Outdated
| @@ -35,7 +37,7 @@ function parseColumns(columns, table_name, extending_type_shorthands = {}) { | |||
| constraints.push(`CHECK (${options.check})`); | |||
| } | |||
| if (options.references) { | |||
| constraints.push(`REFERENCES ${options.references}`); | |||
| constraints.push(`REFERENCES "${schemalize(options.references)}"`); | |||
There was a problem hiding this comment.
I would write it as
template`REFERENCES "${options.references}"`
There was a problem hiding this comment.
Nice, I hadn't noticed that the template function used schemalize. I've made the requested change.
When creating an index on a table where the schema is specified, the schema shouldn't be included in the index name.
dolezel
approved these changes
Aug 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
referenceskey to setup a foreign key constraint.createIndexdon't include the schema when generating a name for the index.[object Object]in the name.