Allow logging function overrides & add more loggers #4
+110
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* You can now override the logger functions to hook into the instance loggers at runtime. * There are also 4 instance loggers available (debug, info, warn, and error). However, only debug and error are injected automatically.
| Object.defineProperty(this, LOGGER, { value: logger }); | ||
| } | ||
| export function debugLogger(key) { | ||
| return key ? window.debug(key) : instanceDebugLogger; |
There was a problem hiding this comment.
Why is debug the only type that allows providing an explicit key?
|
Thanks for the PR! It looks like there are some test failures as the result of this change. I'd also love to see coverage for the expected behavior of the newly-added loggers as well. |
|
Thanks for the feedback, I'll address it and add some fixes to the PR. |
|
@Ramblurr Awesome, thanks. Sorry for the long turnaround! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loggers at runtime.
error). However, only debug and error are injected automatically.