Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis testing #13

Merged
merged 3 commits into from
Sep 28, 2018
Merged

Travis testing #13

merged 3 commits into from
Sep 28, 2018

Conversation

kehphin
Copy link

@kehphin kehphin commented Sep 28, 2018

Accidentally removed .travis.yml - This PR puts it back so we have CI testing.
We also deprecate Node 4 in our testing, requiring a minimum of Node 6.

PR Prime: @dfreeman

package.json Outdated
@@ -14,7 +14,7 @@
"test:all": "ember try:each"
},
"engines": {
"node": "6.* || 8.* || >= 10.*"
"node": "^4.5 || 6.* || >= 7.*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what we had here is fine, since Node 4 is deprecated. We should just update Travis to run with Node 6 instead

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, wasn't sure if we wanted to support users of node 4

@dfreeman
Copy link
Member

Thanks @kehphin!

@kehphin kehphin merged commit 5b072c0 into master Sep 28, 2018
@kehphin kehphin deleted the feature/fix-build branch September 28, 2018 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants