Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set multiple psl #877

Merged
merged 6 commits into from
Feb 26, 2024
Merged

fix: set multiple psl #877

merged 6 commits into from
Feb 26, 2024

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented Feb 23, 2024

What does this PR do?

fix: the gh issue so that you can pass multiple PSL by name, with a nut to validate it
feat: avoid throws for "PSL-not-found" scenario so partial success returns
fix: improper use of ux.table columns that resulted in the error messages not being displayed (only the usernames)
refactor: get rid of the base class and use functions from both commands that need this.

note: the old, deprecated force: version of this command doesn't get the new upgrade to support multiple --name

What issues does this PR fix or reference?

forcedotcom/cli#2744
@W-15109060@

@mshanemc mshanemc changed the title Sm/set multiple psl fix: set multiple psl Feb 23, 2024
@shetzel
Copy link
Contributor

shetzel commented Feb 26, 2024

QA:

plugin-user/bin/run.js org assign permsetlicense -n "Commerce User" -n "Health Cloud"
Warning: The user "[email protected]" already has the Permission Set License "Commerce User"
=== Permset Licenses Assigned

 Username                      Permission Set License Assignment
 ───────────────────────────── ─────────────────────────────────
 [email protected] Commerce User
 [email protected] Health Cloud
plugin-user/bin/run.js org assign permsetlicense -n "Commerce User" -n "Orders Platform"
=== Partial Success

=== Permset Licenses Assigned

Username                      Permission Set License Assignment
───────────────────────────── ─────────────────────────────────
[email protected] Commerce User

=== Failures

Username                      Error Message
───────────────────────────── ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
[email protected] User User can't be assigned the Orders Platform permission set license, because User User's user license doesn't support it.: User ID

@shetzel shetzel merged commit d1c92ff into main Feb 26, 2024
10 checks passed
@shetzel shetzel deleted the sm/set-multiple-psl branch February 26, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants