-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wr/esm #633
Conversation
This issue has been linked to a new work item: W-14374934 |
@@ -44,3 +44,7 @@ node_modules | |||
.idea | |||
|
|||
oclif.manifest.json | |||
|
|||
oclif.lock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only need 1
"/oclif.manifest.json" | ||
"/oclif.manifest.json", | ||
"/oclif.lock", | ||
"/oclif.lock" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
related to oclif.lock - the postpack
and clean:lib
scripts should remove the oclif.lock
too... Probably should add that to our migrate command
src/shared/npmCommand.ts
Outdated
|
||
try { | ||
if (filepath.endsWith('node')) { | ||
// This checks if the filepath is executable on Mac or Linux, if it is not it errors. | ||
// This checks if the filepath is executable on Mac or Linux, if it is not it errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the next 4 changes looks like accidentally added spaces
test/shared/npmCommand.test.ts
Outdated
expect(accessSyncStub).to.have.been.calledOnce; | ||
expect(existsSyncStub).to.have.been.calledTwice; | ||
expect(osTypeStub).to.have.been.calledOnce; | ||
expect(realpathSyncStub).to.have.been.calledOnce; | ||
// expect(realpathSyncStub).to.have.been.calledOnce; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were these a TODO, do the tests not work, has the logic changed, or do these need to be removed?
QA notes: [made a commit with the dev-scripts bump to reduce devDeps and bumped sfdx-core] ./bin/dev.js plugins trust verify -n @salesforce/plugin-org ./bin/dev.js plugins trust verify -n shane-sfdx-plugins [link into sf]
add plugin to allowList, reinstall |
What does this PR do?
ESM
What issues does this PR fix or reference?