fix: add convert command #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shetzel
requested changes
Apr 7, 2021
|
|
||
| if (this.flags.rootdir) { | ||
| path = [this.project.getPackagePath(this.flags.rootdir)]; | ||
| } |
There was a problem hiding this comment.
This doesn't look right. The rootdir can be (and typically is) outside of the project's packageDirectories. If they want to choose a file or directory within the project's packageDirs then they should use the sourcepath param.
We'll need to validate rootdir and use it in conjunction with any other params to match the toolbelt version.
src/commands/force/source/convert.ts
Outdated
| } | ||
|
|
||
| const cs = await this.createComponentSet({ | ||
| sourcepath: asArray<string>(path || this.flags.sourcepath), |
There was a problem hiding this comment.
I think we want to concat the paths. Test with toolbelt to see what it does. I'm not 100% on this usecase.
shetzel
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
adds the
source:convertcommandWhat issues does this PR fix or reference?
@W-9091465@