Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pull non-default directory in default project #471

Merged
merged 3 commits into from
Apr 28, 2022

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented Apr 25, 2022

Nut for forcedotcom/source-tracking#150

What does this PR do?

use new STL method for generating a componentSet that mixes SourceComponent (where the exist) with metadataMember (where they are remote only) to ensure that the retrieved components don't duplicate to default dir

What issues does this PR fix or reference?

https://github.com/forcedotcom/cli/issues/1485](https://github.com/forcedotcom/cli/issues/1485
@W-11047555@
forcedotcom/cli#1471
@W-11003710@)

Copy link
Contributor

@shetzel shetzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can merge as is, but that comment either needs updating or removal. There should be a NUT added to cover this usecase as well, but that can go in another PR in the interest of getting this in for RC.


// if it is't local, add it as a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this just be removed?

@shetzel shetzel merged commit 02d91ca into main Apr 28, 2022
@shetzel shetzel deleted the sm/component-set-for-pull branch April 28, 2022 17:24
@cromwellryan
Copy link
Member

@shetzel , I see a few questions about NUTS and comments that need removed. I don't see a response. Did you intend to move this through? Can either you or @mshanemc clear up the confusion if someone on the team or community looks into this PR for clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants