Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sm/status-shows-ignores #258

Merged
merged 44 commits into from
Oct 23, 2021
Merged

Conversation

mshanemc
Copy link
Contributor

What does this PR do?

Draft because requires 2 PRs:
forcedotcom/source-tracking#40 which requires forcedotcom/source-deploy-retrieve#479

PR feedback from #209

  • moves most status logic from plugin-source to STL
  • renames command classes
  • remove ebikes repo

other:

  • feat (@W-9805809@) status shows ignored files (ex: SourceTrackingResetCommand -> Reset)
  • extends json output of status with ignored AND disaggregation of state property (fancy TS literal for state prop)
  • Flags: remove the --all flag on status, make remote/local exclusive
  • fix push json output
  • includes changes from Sm/push-json #252 and Sm/conflicts-for-labels #244
  • changes UT to not run on latest

mshanemc and others added 30 commits October 7, 2021 15:12
* test: one NUT for special types

* test: remove tracking NUTs

* ci: custom nut commands

* test: fix folderTypes, cross-env for windows

* test:  cross-env for windows SEED_FILTER, nyc only top-level

* ci: no sha; change nut order

* test: deploy nuts in parallel

* ci: disable async nuts

* test: exclude async nuts

* test: revert async-exclude

* test: revert tsconfig, revert config.yml

* test: exclude env for seeds
mshanemc and others added 4 commits October 20, 2021 13:18
* fix: implementing destructive change deploy, 1 NUT

* chore: add NUTs, fix UTs

* chore: post-review board updates

* chore: fix linting

* chore: minor updates to flag logic, redo NUT query method

* chore: remove unnecessary checks in NUTs

* chore: bump SDR to 5, include deploy:destructive in NUTs
@mshanemc mshanemc mentioned this pull request Oct 21, 2021
@mshanemc mshanemc mentioned this pull request Oct 21, 2021
@@ -52,7 +52,7 @@ workflows:
- linux
- windows
node_version:
- latest
# - latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node latest is v17 and there's an temporary issue with that

@@ -12,7 +12,7 @@
{
"command": "force:source:beta:status",
"plugin": "@salesforce/plugin-source",
"flags": ["all", "apiversion", "json", "local", "loglevel", "remote", "targetusername"]
"flags": ["apiversion", "json", "local", "loglevel", "remote", "targetusername"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we able to remove the 'all' flag without deprecation?

@mshanemc mshanemc marked this pull request as ready for review October 22, 2021 20:53
@mshanemc mshanemc merged commit c031b1f into sm/source-tracking-beta Oct 23, 2021
@mshanemc mshanemc deleted the sm/status-shows-ignores branch October 23, 2021 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants