Skip to content

Commit

Permalink
fix: add retrieve via packageNames param
Browse files Browse the repository at this point in the history
  • Loading branch information
WillieRuemmele committed Feb 24, 2021
1 parent abba216 commit 2fb3217
Show file tree
Hide file tree
Showing 4 changed files with 63 additions and 455 deletions.
12 changes: 6 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
"devDependencies": {
"@oclif/dev-cli": "^1",
"@oclif/plugin-command-snapshot": "^2.0.0",
"@salesforce/dev-config": "^2.1.0",
"@salesforce/cli-plugins-testkit": "^0.0.8",
"@salesforce/dev-config": "^2.1.0",
"@salesforce/dev-scripts": "^0.7.0",
"@salesforce/plugin-command-reference": "^1.3.0",
"@salesforce/prettier-config": "^0.0.2",
Expand All @@ -25,24 +25,24 @@
"@typescript-eslint/parser": "^4.2.0",
"chai": "^4.2.0",
"cz-conventional-changelog": "^3.3.0",
"eslint": "^7.20.0",
"eslint": "^6.8.0",
"eslint-config-prettier": "^6.11.0",
"eslint-config-salesforce": "^0.1.0",
"eslint-config-salesforce-license": "^0.1.0",
"eslint-config-salesforce-typescript": "^0.2.0",
"eslint-plugin-header": "^3.0.0",
"eslint-plugin-import": "^2.20.2",
"eslint-plugin-jsdoc": "^32.0.2",
"eslint-plugin-jsdoc": "^27.0.3",
"eslint-plugin-prettier": "^3.1.3",
"husky": "^4.2.5",
"lint-staged": "^10.2.2",
"mocha": "^8.3.0",
"mocha": "^7.2.0",
"nyc": "^15.1.0",
"prettier": "^2.0.5",
"pretty-quick": "^3.1.0",
"pretty-quick": "^2.0.1",
"shx": "0.3.3",
"sinon": "^9.0.2",
"ts-node": "^9.1.1",
"ts-node": "^8.10.2",
"typescript": "^4.1.3"
},
"config": {
Expand Down
6 changes: 2 additions & 4 deletions src/commands/force/source/retrieve.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,7 @@ export class retrieve extends SourceCommand {
usernameOrConnection: this.org.getUsername(),
merge: true,
output: (this.flags.sourcepath as string) ?? defaultPackage.path,
// TODO: fix this once wait has been updated in library
// wait: (this.flags.wait as Duration).milliseconds,
// TODO: implement retrieve via package name
// package: options.packagenames
packageNames: asArray<string>(this.flags.packagenames),
})
.start();

Expand All @@ -89,6 +86,7 @@ export class retrieve extends SourceCommand {
if (results.status === 'InProgress') {
throw new SfdxError(messages.getMessage('retrieveTimeout', [(this.flags.wait as Duration).minutes]));
}
this.ux.logJson(mdapiResult.getFileResponses());
// this.printTable(results, true);

return results;
Expand Down
4 changes: 2 additions & 2 deletions src/sourceCommand.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ export abstract class SourceCommand extends SfdxCommand {
}

if (options.packagenames) {
// retrieve only
// TODO: @W-8908888@
// return ComponentSet and use packageNames in the library via `.retrieve` options
setAggregator.push(...new ComponentSet([]));
}

if (options.manifest) {
Expand Down
Loading

0 comments on commit 2fb3217

Please sign in to comment.