Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: warn when attempting to unset a global config without flag #346

Merged
merged 5 commits into from
Aug 10, 2023

Conversation

WillieRuemmele
Copy link
Contributor

What does this PR do?

warns when attempting to unset a global config without the --global flag because the output is confusing

What issues does this PR fix or reference?

@W-13825061@

@WillieRuemmele WillieRuemmele requested a review from a team as a code owner August 7, 2023 20:14
Copy link
Contributor

@jshackell-sfdc jshackell-sfdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small edit, but approving anyway 'cause I know you'll deal with it :)

messages/config.unset.md Outdated Show resolved Hide resolved
src/commands/config/unset.ts Outdated Show resolved Hide resolved
@shetzel
Copy link
Contributor

shetzel commented Aug 10, 2023

QA:
✅ - unset local only
✅ - unset global only
✅ - unset local (with nothing set) with global still there. warns about the global still being set.
✅ - unset local (with it set) with global still there. warns about the global still being set.

@shetzel shetzel merged commit b573611 into main Aug 10, 2023
@shetzel shetzel deleted the wr/globalUnsetWarning branch August 10, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants