Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: print errors when reporting on a new PV with errors #181

Merged
merged 3 commits into from
Dec 7, 2022

Conversation

WillieRuemmele
Copy link
Contributor

What does this PR do?

force:package:beta:version:create:report now will include errors

 ➜  sfdx force:package:beta:version:create:report -i 08c3i000000fyoVAAQ 
=== Package Version Create Request

 Name                          Value              
 ───────────────────────────── ────────────────── 
 ID                            08c3i000000fyoVAAQ 

=== Errors

(1) Create_property: geocode_address (Action) - We can't find an action with the name and action type that you specified.
(2) dreamhouse: In field: apexClass - no ApexClass named PagedResult found
(3) PropertyController: Variable does not exist: result
(4) PropertyController: Variable does not exist: result

changes the --json output to match toolbelt, toolbelt has an array of results, we were just returning the result

 ➜  sfdx force:package:version:create:report -i 08c3i000000fyoVAAQ  --json
{
  "status": 0,
+  "result": [ {
- "result": {
      "Id": "08c3i000000fyoVAAQ",

What issues does this PR fix or reference?

@W-11983124@
forcedotcom/cli#1779

@WillieRuemmele WillieRuemmele requested a review from a team as a code owner December 7, 2022 16:49
@shetzel shetzel merged commit 46bed82 into main Dec 7, 2022
@shetzel shetzel deleted the wr/reportErrors branch December 7, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants