fix: improve handling of pvc path flag #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@W-11903179@
shetzel
requested changes
Oct 17, 2022
| @@ -221,4 +209,24 @@ export class PackageVersionCreateCommand extends SfdxCommand { | |||
| } | |||
| return result; | |||
| } | |||
|
|
|||
| private resolvePackageIdFromFlags(): string { | |||
There was a problem hiding this comment.
PackageVersion.create() handles all of this already right? That's what I see when looking at library code for packageVersionCreate.packageVersionCreate().
There was a problem hiding this comment.
It should (there is a bug in that code), but I really do not like passing a path as an id or alias. To me it is just making the determination of which package much more difficult.
shetzel
approved these changes
Oct 18, 2022
WillieRuemmele
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improves handling of the path flag for package version create
What issues does this PR fix or reference?
@W-11903179@ GH issue