fix(org status): improve err handling #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristiand391
commented
Oct 23, 2023
| stubMethod(sandbox, Org.prototype, 'refreshAuth').rejects({ | ||
| message: ` | ||
| <!DOCTYPE HTML> | ||
| <html lang=en-US> |
There was a problem hiding this comment.
this is the error sfdx-core got when trying to resolve my dev ed org with an invalid instance URL.
plugin-org looks for <html> so it doesn't catch these HTML responses (html tag with attributes>). Now will also look for <!DOCTYPE HTML>.
with org api:
➜ plugin-org git:(cd/improve-html-res-handle) sf org api 'services/data/v59.0/'
Error (1): <!DOCTYPE HTML>
<html lang=en-US>
<head>
<meta charset=UTF-8>
<title>Error Page</title>
<style>
/*! normalize.css v3.0.2 | MIT License | git.io/normalize */
html {
font-family: sans-serif;
-ms-text-size-adjust: 100%;
-webkit-text-size-adjust: 100%
}
body {
margin: 0
}
article,
aside,
details,
figcaption
mshanemc
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improves error handler when trying to get status of an org.
before:
org listwould check for<html>in err messageafter:
org listwill check forhtmlor<!DOCTYPE HTML>to ensure it got an HTML response from the server.Repro:
modify the instance url (make it point to an invalid url) of a non-hub org in its auth file, then run
sf org listWhat issues does this PR fix or reference?
forcedotcom/cli#2533
@W-14348441@