Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more scratch org creation flags #641

Merged
merged 6 commits into from
Apr 18, 2023
Merged

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented Apr 11, 2023

What does this PR do?

4 new flags to allow overrides of scratch def
1 nut to test 3 of them (we can't do release becuase it's not always available)

What issues does this PR fix or reference?

@W-12746098@
forcedotcom/cli#2016

Release Notes

org scratch create has 4 new flags for values from scratch-org-def.json and override properties in the scratch def.

  • username
  • description
  • name (maps to orgName in the file)
  • release

Additionally, you can now use both a definition file AND the existing --edition flag (it'll override the edition property in the definition file)

@mshanemc mshanemc requested a review from jshackell-sfdc April 11, 2023 16:45
@peternhale
Copy link
Contributor

peternhale commented Apr 14, 2023

QA Notes

  • config file with missing edition ✅
org org:create:scratch --definition-file config/project-scratch-def-copy.json 

Error (1): You must specify an edition when creating a scratch org.
Creating Scratch Org... done
  • config file with missing edition and --edition developer
    Given that we have so many flags now that are used to supplement the config, maybe --edition should be treated the same way. I can see setting up a config that is missing edition when an org is testing their changes across edition types.
org org:create:scratch --definition-file config/project-scratch-def-copy.json --edition developer
Error (1): The following errors occurred:
  --definition-file cannot also be provided when using --edition
  --edition cannot also be provided when using --definition-file
  • Just edition ✅
  • overrides ✅
  • Running command with no flags ✅
org org:create:scratch

Error (1): You must specify an edition when creating a scratch org.

@peternhale
Copy link
Contributor

@mshanemc your response to?

Given that we have so many flags now that are used to supplement the config, maybe --edition should be treated the same way. I can see setting up a config that is missing edition when an org is testing their changes across edition types.

@mshanemc mshanemc requested a review from peternhale April 14, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants