fix: allow expired orgs to be deleted #640
Conversation
| } catch (e) { | ||
| if (e instanceof Error && e.name === 'ScratchOrgNotFound') { | ||
| if (e instanceof Error && e.name === 'DomainNotFoundError') { |
There was a problem hiding this comment.
where does error happen from core? Asking because .delete doesn't need to auth to the org, but does need to auth the hub and there could be a DomainNotFoundError coming from the hub. Then you could get into a weird place where the scratch org never got deleted
|
QA Notes deleted an expired (deleted) org with force:org:delete -u, and one with -o ✅✅ put an alias on an expired org, and delete it via force:org:delete ✅ alias is removed from alias:list ✅ not tested: deleting sandboxes via force:org:delete |
|
@mshanemc since this is merged to main should we already be seeing it in |
What does this PR do?
allows expired orgs to be deleted
What issues does this PR fix or reference?
@W-12992139@
forcedotcom/cli#2045