Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use newer core scratchOrgCreate #357

Merged
merged 3 commits into from
Jul 15, 2022
Merged

fix: use newer core scratchOrgCreate #357

merged 3 commits into from
Jul 15, 2022

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented Jul 13, 2022 •
edited
Loading

requires forcedotcom/sfdx-core#620

What does this PR do?

org:beta:create will use the latest sfdx-core scratchOrgCreate code so that it

  1. sets the alias properly @W-11404235@
  2. sets tracksSource property on the org to account for non-prod environments that answer isSandbox() incorrectly @W-11357043@

forcedotcom/cli#1630

@maggiben
Copy link
Contributor

QA:

  • sets alias
  • sets defaultusername (Local)

@mshanemc mshanemc requested a review from shetzel July 14, 2022 23:09
@maggiben maggiben merged commit 54612f2 into main Jul 15, 2022
@maggiben maggiben deleted the sm/fix-alias branch July 15, 2022 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maggiben maggiben maggiben approved these changes

@shetzel shetzel Awaiting requested review from shetzel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mshanemc @maggiben