Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: proxy support for got #75

Merged
merged 2 commits into from
Feb 10, 2022
Merged

fix: proxy support for got #75

merged 2 commits into from
Feb 10, 2022

Conversation

mshanemc
Copy link
Contributor

What does this PR do?

adds proxy support for got
proxy implementation is based on plugin-release-mgmt

What issues does this PR fix or reference?

@W-10493241@

cristiand391
cristiand391 approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@cristiand391 cristiand391 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA notes:

Used my raspberry pi as a proxy server with Privoxy.

✅ plugin-info respects HTTPS_PROXY env var.

Screen Shot 2022-02-10 at 12 34 35

@cristiand391 cristiand391 merged commit 2d9abef into main Feb 10, 2022
@cristiand391 cristiand391 deleted the sm/proxy-fix branch February 10, 2022 15:40
@mshanemc mshanemc mentioned this pull request Feb 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillieRuemmele WillieRuemmele WillieRuemmele approved these changes

@cristiand391 cristiand391 cristiand391 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mshanemc @cristiand391 @WillieRuemmele