Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename flag --environment to --target-env #92

Merged
merged 10 commits into from
Jul 21, 2021
Merged

Conversation

peternhale
Copy link
Contributor

What does this PR do?

renames flag --environment to --target-env

What issues does this PR fix or reference?

@W-9623159@

@peternhale peternhale changed the title fix: renamte flag --environment to --target-env fix: rename flag --environment to --target-env Jul 20, 2021
Copy link
Contributor

@RodEsp RodEsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.

src/commands/env/display.ts Outdated Show resolved Hide resolved
RodEsp
RodEsp previously approved these changes Jul 21, 2021
RodEsp
RodEsp previously approved these changes Jul 21, 2021
.circleci/config.yml Outdated Show resolved Hide resolved
Co-authored-by: Rodrigo Espinosa de los Monteros <[email protected]>
@peternhale peternhale requested a review from RodEsp July 21, 2021 16:43
@RodEsp RodEsp merged commit d0c8f47 into main Jul 21, 2021
@RodEsp RodEsp deleted the phale/W-9623159 branch July 21, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants