Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: migrate to ESM #751

Merged
merged 2 commits into from
Nov 8, 2023
Merged

feat!: migrate to ESM #751

merged 2 commits into from
Nov 8, 2023

Conversation

mdonnalley
Copy link
Contributor

What does this PR do?

Migrate to ESM

What issues does this PR fix or reference?

@W-14447385@

BREAKING CHANGES: ESM and node 18 minimum
@@ -62,7 +61,8 @@
"env": {
"description": "Commands to manage your environments, such as orgs and compute environments."
}
}
},
"flexibleTaxonomy": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't comment because there's no changes - but the clean:lib and postpack scripts should delete oclif.lock

@WillieRuemmele
Copy link
Contributor

QA Notes


NOTE: I don't have any functions envs to interact with, all commands exited - but code changes are clean

➜ ../../oss/plugin-env/bin/run.js env:open
➜ ../../oss/plugin-env/bin/run.js env:list
➜ ../../oss/plugin-env/bin/run.js env:display

@WillieRuemmele WillieRuemmele merged commit fd415e9 into main Nov 8, 2023
9 checks passed
@WillieRuemmele WillieRuemmele deleted the mdonnalley/esm branch November 8, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants